Very important includeDocuments Function is commented out / disabled in PHP SDK

Frostik · January 6, 2018, 1:27pm

Hello,

Thank you for your hard work on Couchbase!

We’re really missing the includeDocuments Function in PHP SDK. with them we can’t emit null for doc and need to emit always the complete doc.

Is there any reason why the function is disabled and can we pull it in the next release?

github.com

couchbase/php-couchbase/blob/178403a95440df9003d4a2b4ad0d8df5075ca5ac/src/couchbase/spatial_view_query.c#L407


PHP_ME(SpatialViewQuery, from, ai_SpatialViewQuery_from, ZEND_ACC_STATIC | ZEND_ACC_PUBLIC)
PHP_ME(SpatialViewQuery, encode, ai_SpatialViewQuery_none, ZEND_ACC_PUBLIC)
PHP_ME(SpatialViewQuery, limit, ai_SpatialViewQuery_limit, ZEND_ACC_PUBLIC)
PHP_ME(SpatialViewQuery, skip, ai_SpatialViewQuery_skip, ZEND_ACC_PUBLIC)
PHP_ME(SpatialViewQuery, consistency, ai_SpatialViewQuery_consistency, ZEND_ACC_PUBLIC)
PHP_MALIAS(SpatialViewQuery, stale, consistency, ai_SpatialViewQuery_consistency, ZEND_ACC_PUBLIC) // ZEND_ACC_DEPRECATED
PHP_ME(SpatialViewQuery, bbox, ai_SpatialViewQuery_bbox, ZEND_ACC_PUBLIC)
PHP_ME(SpatialViewQuery, startRange, ai_SpatialViewQuery_range, ZEND_ACC_PUBLIC)
PHP_ME(SpatialViewQuery, endRange, ai_SpatialViewQuery_range, ZEND_ACC_PUBLIC)
PHP_ME(SpatialViewQuery, custom, ai_SpatialViewQuery_custom, ZEND_ACC_PUBLIC)
/* PHP_ME(SpatialViewQuery, includeDocuments, ai_SpatialViewQuery_includeDocuments, ZEND_ACC_PUBLIC) */
PHP_FE_END
};
// clang-format on


zend_object_handlers spatial_view_query_handlers;


static void spatial_view_query_free_object(pcbc_free_object_arg *object TSRMLS_DC) /* {{{ */
{
pcbc_spatial_view_query_t *obj = Z_SPATIAL_VIEW_QUERY_OBJ(object);

github.com

couchbase/php-couchbase/blob/178403a95440df9003d4a2b4ad0d8df5075ca5ac/src/couchbase/view_query.c#L569


PHP_ME(ViewQuery, order, ai_ViewQuery_order, ZEND_ACC_PUBLIC)
PHP_ME(ViewQuery, reduce, ai_ViewQuery_reduce, ZEND_ACC_PUBLIC)
PHP_ME(ViewQuery, group, ai_ViewQuery_group, ZEND_ACC_PUBLIC)
PHP_ME(ViewQuery, groupLevel, ai_ViewQuery_groupLevel, ZEND_ACC_PUBLIC)
PHP_MALIAS(ViewQuery, group_level, groupLevel, ai_ViewQuery_groupLevel, ZEND_ACC_PUBLIC) // ZEND_ACC_DEPRECATED
PHP_ME(ViewQuery, key, ai_ViewQuery_key, ZEND_ACC_PUBLIC)
PHP_ME(ViewQuery, keys, ai_ViewQuery_keys, ZEND_ACC_PUBLIC)
PHP_ME(ViewQuery, range, ai_ViewQuery_range, ZEND_ACC_PUBLIC)
PHP_ME(ViewQuery, idRange, ai_ViewQuery_idRange, ZEND_ACC_PUBLIC)
PHP_MALIAS(ViewQuery, id_range, idRange, ai_ViewQuery_idRange, ZEND_ACC_PUBLIC) // ZEND_ACC_DEPRECATED
/* PHP_ME(ViewQuery, includeDocuments, ai_ViewQuery_includeDocuments, ZEND_ACC_PUBLIC) */
PHP_FE_END
};
// clang-format on


zend_object_handlers view_query_handlers;


static void view_query_free_object(pcbc_free_object_arg *object TSRMLS_DC) /* {{{ */
{
pcbc_view_query_t *obj = Z_VIEW_QUERY_OBJ(object);