Java SDK v3.0.2 get operations misleading

ashernave · April 7, 2020, 2:45pm

There is a conflicting documentation between what Collection.get and ReactiveCollection.get do when document is missing. Collection,get throws an exception if document not found.
Reactive Collection documentation says it should return empty Mono. it doesn’t. it throws an exception. Previous sdk version returned empty Maybe.

daschl · April 7, 2020, 2:51pm

@ashernave can you please link the documentation that’s outdated? In SDK 3 yes both the blocking and reactive API should and will throw an exception (not return an empty mono)

ashernave · April 7, 2020, 3:02pm

github.com

couchbase/couchbase-jvm-clients/blob/a0e78a3142d51e87b0c7a5dc1b7a09bcace0db77/java-client/src/main/java/com/couchbase/client/java/ReactiveCollection.java#L209


 *
 * @return the {@link ReactiveBinaryCollection}.
 */
public ReactiveBinaryCollection binary() {
  return reactiveBinaryCollection;
}


/**
 * Fetches a Document from a collection with default options.
 *
 * <p>If the document has not been found, this {@link Mono} will be empty.</p>
 *
 * @param id the document id which is used to uniquely identify it.
 * @return a {@link Mono} indicating once loaded or failed.
 */
public Mono<GetResult> get(final String id) {
  return get(id, DEFAULT_GET_OPTIONS);
}


/**
 * Fetches a Document from a collection with custom options.

daschl · April 7, 2020, 3:27pm

@ashernave thanks! We’ll get it fixed.