Thank you for the info, that’s fair enough. I was going to look into coming up with a more elegant fix, but I see that you’ve gone ahead and added in a check already. On the topic of contributing, do you know if there are separate CLAs for individuals and corporate contributors? Thus far I’ve only been commenting here with regards to solving a few build issues, but I am working on behalf of a large company which may wish to contribute back once things get further along.
Getting back to the endianness issue, making sure that WORDS_BIGENDIAN is defined seems to deal with most of the issues I’ve been seeing, but to be sure, do you know if there were any other similar macros in different modules that now go undefined? Looking through the codebase I see a lot of different endianness-related macros, but most of them seem to be defined based on WORDS_BIGENDIAN.
If I can bother you a little further, I was also curious about one of your commits, which appears to have first been used in membase/moxi/config_static.h:
#if defined(WORDS_BIGENDIAN) && WORDS_BIGENDIAN > 1
#define ENDIAN_BIG 1
#else
#define ENDIAN_LITTLE 1
#endif
Why the check to see if it’s greater than one? Is there some additional convention to the value beyond simply defining the macro?
Thank you very much for your insight.