Thanks @btburnett3 .
Trying to get used to the Gerrit flow, but don’t think i have a really good hang of it (I usually only use Git via the Visual Studio interface with very minimal command-line usage).
Sorry, I’m a bit lost on what to do next. I thought I had pushed the changes and triggered another round of reviews on the original review page (166541), but when I logged in today, I saw that I had to click “Reply” on the code review comment responses.
I did that, then noticed there was a “Merge” conflict. Following the onscreen help/notes, I rebased, reapplied changes, then followed the patch instructions:
a) Pull down latest patchset (use the DOWNLOAD & Checkout command on the right hand side)
b) Make your changes
c) Do a git add .
d) Do a git commit --amend
e) Do a git push origin HEAD:refs/for/master
but it seems to create a new review instead of pushing the changes to this one (166541) (I’m probably doing something wrong)?
The original review 166541 still doesn’t have my pushed changes (var rename, etc.), but the new review ( 166625) does. Might be cleaner to just start fresh with the new review, so I added you and Jeff as reviewers again (sorry for the trouble!).
https://review.couchbase.org/c/couchbase-net-client/+/166625
If you guys are ok with using the new review, I’ll go and abandon the other one later?