[CCBC-515] lcb_rget3 does not check for missing configuration Created: 17/Sep/14  Updated: 19/Sep/14  Resolved: 19/Sep/14

Status: Resolved
Project: Couchbase C client library libcouchbase
Component/s: library
Affects Version/s: 2.4.0
Fix Version/s: 2.4.2
Security Level: Public

Type: Task Priority: Major
Reporter: Mark Nunberg Assignee: Mark Nunberg
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   
The library does not check for a missing configuration in the rget3() API call, thus calling this function on a non-bootstrapped client will segfault rather than return with an error.

 Comments   
Comment by Mark Nunberg [ 17/Sep/14 ]
http://review.couchbase.org/#/c/41464/




[CCBC-512] Docs state that getl will prevent all future access Created: 11/Sep/14  Updated: 18/Sep/14  Resolved: 18/Sep/14

Status: Resolved
Project: Couchbase C client library libcouchbase
Component/s: docs
Affects Version/s: 2.4.1
Fix Version/s: 2.4.2
Security Level: Public

Type: Bug Priority: Major
Reporter: Perry Krug Assignee: Mark Nunberg
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   
Under this link: http://docs.couchbase.com/sdk-api/couchbase-c-client-2.4.0/group___l_c_b___g_e_t.html

The text:
If this parameter is set then the server will in addition to retrieving the item also lock the item, making it so that other operations to access the same item will fail with an error (either LCB_KEY_EEXISTS or LCB_ETMPFAIL). The key will only be accessible again once:
-The lock timeout expires
-The item is unlocked with the cas returned in the response
-The item is modified with the cas returned in the response

Is not correct about "other operations". In fact, other operations (both read and modify) would receive no error. The text could be simply modified to be "other operations with the lock bit set"

 Comments   
Comment by Mark Nunberg [ 11/Sep/14 ]
http://review.couchbase.org/41380




[CCBC-129] Add libevent support for win32 Created: 20/Nov/12  Updated: 18/Sep/14  Resolved: 18/Sep/14

Status: Resolved
Project: Couchbase C client library libcouchbase
Component/s: None
Affects Version/s: 2.0.0beta2
Fix Version/s: None
Security Level: Public

Type: New Feature Priority: Minor
Reporter: Brett Harrison Assignee: Mark Nunberg
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Zip Archive win32libevent.zip    

 Description   
I created a NMakefile and made changes to the code to support libevent on windows.

Files affected:
iofactory.c
plugin-libevent.c

New file:
NMakefile.libevent

I uploaded a zipfile of the changes if you are interested in merging them.

 Comments   
Comment by Sergey Avseyev [ 21/Nov/12 ]
it would be awesome if you can move your patch to our review system. http://review.couchbase.com
Comment by Brett Harrison [ 21/Nov/12 ]
Is there a guild on how to use the review system? If you can explain the steps I'll upload the patch.
Comment by Matt Ingenthron [ 21/Nov/12 ]
It's roughly http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes

Repo tool isn't required for this project though
Comment by Matt Ingenthron [ 21/Nov/12 ]
Also, Brett: saw your CLA on review.couchbase.org and you're all set.
Comment by Mark Nunberg [ 18/Sep/14 ]
Unfortunately libevent doesn't really support Windows except by means of gcc/autotools and some other complicated steps. Given that we only support our binary Visual Studio builds, getting libevent to run well on Windows would be not very fruitful. We might revisit this if and when libevent will support Visual Studio. Until then, I'm marking this as won't fix.




[CCBC-514] helper headers have different install targets depending on build system Created: 16/Sep/14  Updated: 17/Sep/14  Resolved: 17/Sep/14

Status: Resolved
Project: Couchbase C client library libcouchbase
Component/s: library
Affects Version/s: 2.4.0
Fix Version/s: 2.4.2
Security Level: Public

Type: Task Priority: Major
Reporter: Mark Nunberg Assignee: Mark Nunberg
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   
The helper headers such as 'bsdio-inl' and friends have different install paths depending on whether autotools or cmake is being used.




[CCBC-513] cmake does not install all files needed Created: 15/Sep/14  Updated: 17/Sep/14  Resolved: 17/Sep/14

Status: Resolved
Project: Couchbase C client library libcouchbase
Component/s: library
Affects Version/s: 2.4.1
Fix Version/s: 2.4.2
Security Level: Public

Type: Bug Priority: Major
Reporter: Sergey Avseyev Assignee: Mark Nunberg
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   
ERROR: Error installing couchbase: [15/242]
        ERROR: Failed to build gem native extension.

    ~/.rbenv/versions/2.1.0/bin/ruby -r ./siteconf20140915-28269-a46nh0.rb extconf.rb
checking for lcb_set_bootstrap_callback(NULL, NULL) in -lcouchbase... yes
checking for mach/mach_time.h... no
checking for stdint.h... yes
checking for sys/time.h... yes
checking for fcntl.h... yes
checking for sys/socket.h... yes
checking for errno.h... yes
checking for st_index_t... yes
checking for clock_gettime()... yes
checking for gettimeofday()... yes
checking for QueryPerformanceCounter()... no
checking for gethrtime()... yes
checking for rb_hash_lookup2()... yes
checking for rb_thread_fd_select()... yes
checking for rb_thread_blocking_region()... yes
checking for rb_thread_call_without_gvl()... yes
checking for poll() in poll.h... yes
checking for ppoll() in poll.h... yes
checking for rb_fiber_yield()... yes
creating couchbase_config.h
creating Makefile

make "DESTDIR=" clean

make "DESTDIR="
compiling multithread_plugin.c
multithread_plugin.c:30:36: fatal error: libcouchbase/bsdio-inl.c: No such file or directory
 #include <libcouchbase/bsdio-inl.c>
                                    ^
compilation terminated.
Makefile:224: recipe for target 'multithread_plugin.o' failed
make: *** [multithread_plugin.o] Error 1

make failed, exit code 2

Gem files will remain installed in /home/arashm/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/couchbase-1.3.9 for inspection.
Results logged to /home/arashm/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/extensions/x86_64-linux/2.1.0-static/couchbase-1.3.9/gem_make.out


 Comments   
Comment by Mark Nunberg [ 15/Sep/14 ]
http://review.couchbase.org/41421




[CCBC-508] hashkey needs to be marked as volatile and clear that it's experimental and libmemcached compat oriented Created: 10/Sep/14  Updated: 16/Sep/14  Resolved: 16/Sep/14

Status: Resolved
Project: Couchbase C client library libcouchbase
Component/s: None
Affects Version/s: 2.0.7, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.4.1
Fix Version/s: 2.4.2
Security Level: Public

Type: Bug Priority: Blocker
Reporter: Matt Ingenthron Assignee: Mark Nunberg
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   
This isn't described correctly in the API documentation and needs to be.

Please do so in any source code as well so it's not accidentally discovered. This is not a feature of the system currently.

Recommended text for a comment:
/* Note that hashkey/groupid is not a supported feature of Couchbase Server and this client. It should be considered volatile and experimental. Using this could lead to an unbalanced cluster, inability to interoperate with the data from other languages, not being able to use the Couchbase Server UI to look up documents and other possible future upgrade/migration concerns. */

 Comments   
Comment by Mark Nunberg [ 10/Sep/14 ]
http://review.couchbase.org/#/c/41317/




Generated at Mon Sep 22 20:53:42 CDT 2014 using JIRA 5.2.4#845-sha1:c9f4cc41abe72fb236945343a1f485c2c844dac9.