Couchbase

Couchbase http://www.couchbase.com/issues This file is an XML representation of an issue en-us

5.2.4

845

26-12-2012

[PCBC-147] Segmentation Fault (segfault) when querying view http://www.couchbase.com/issues/browse/PCBC-147 Couchbase PHP client library When doing a query against a view, the php application segfaults. Set/get/delete commands all work fine. <br/> <br/> Attached is an strace, a stack trace from gdb, and various other support files, including the repro script. PHP 5.3.13 / 5.3.15, Redhat 5.6 PCBC-147

Segmentation Fault (segfault) when querying view

Bug Blocker Resolved Fixed Public Mark Nunberg Jeff Minard Thu, 15 Nov 2012 15:58:59 -0600 Mon, 19 Nov 2012 01:51:53 -0600 Mon, 19 Nov 2012 01:51:53 -0600 1.1.0-dp5 1.1.0 library 0 1 I was asked to run a gdb, but I don't really think it looks that helpful. I've attached it. gdb file, looks pretty useless without a php debug symbols version My bad. Type 'bt' when you get the segfault :) <br/> <br/> That'll show you the stack trace Yes, this looks much more helpful :) Here is the same segfault when using the latest couchbase.so compiled from the github master branch (so, cutting edge, I'd seen some lcb changes, so I figured I'd give ya both). Can you try this patch? <br/> <br/> diff --git a/views.c b/views.c <br/> index 6c7bc30..7d03c5a 100644 <br/> --- a/views.c <br/> +++ b/views.c <br/> @@ -52,12 +52,13 @@ void php_couchbase_complete_callback(lcb_http_request_t request, <br/>                 return; <br/>         } <br/>   <br/> + /** We have one extra byte in 'data' */ <br/>         hti = emalloc(sizeof(*hti) + resp->v.v0.nbytes); <br/>         hti->ndata = resp->v.v0.nbytes; <br/> - memcpy(hti->data, resp->v.v0.bytes, hti->ndata + 1); <br/> + <br/>         if (hti->ndata) { <br/> - hti->data[hti->ndata - 1] = '\0'; <br/> - hti->ndata--; <br/> + memcpy(hti->data, resp->v.v0.bytes, hti->ndata); <br/> + hti->data[hti->ndata] = '\0'; <br/>         } <br/>   <br/>         ctx->res->rc = error; <br/> <br/> I'll make it as a gerrit changeset as well.. <br/> <a href="http://review.couchbase.org/22573">http://review.couchbase.org/22573</a> That changed fixed the segfault, yes. The value assigned to the variable from the $cb->view() call is bool(false) Thanks for the quick work Mark! Looks like it'll be closeable after it's reviewed and in. Rank 9760 Time In Status