[SPY-78] TAP operation messages may never be removed from the TAP stream Created: 18/Feb/12 Updated: 05/Jun/12 |
|
| Status: | Open |
| Project: | Spymemcached Java Client |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Security Level: | Public |
| Type: | Bug | Priority: | Critical |
| Reporter: | Matt Ingenthron | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
When looking through the TapStream abstraction added, I see it creates an ArrayList of operations (being sent to the server it seems?) but never cleans them up. This would be a reference leak with a long running TAP.
|
| Comments |
| Comment by Matt Ingenthron [ 18/Feb/12 ] |
| Assigning to Mike just to ask for verification of behavior here. If this is an actual issue, Rags or I can fix it, but I don't fully understand the TapStream abstraction. |
| Comment by Mike Wiederhold [ 21/Feb/12 ] |
| Those are your handles to the tap stream. Those operations need to stay around until the tap stream is finished since their completed() function is only called once the tap stream is finished. |