[PCBC-197] different parameter order for incremement Created: 05/Feb/13 Updated: 01/Oct/13 Resolved: 01/Oct/13
|Project:||Couchbase PHP client library|
|Reporter:||Trond Norbye||Assignee:||Brett Lawson|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
lachlan: can the latest php sdk (couchbase.so) still to be a drop in replacement for php memcached?
[2:39pm] trondn: lachlan: it is supposed to be compatible, but the constructor/factory methods are named differently etc..
[2:39pm] lachlan: reason I ask is the different order of parameters for increment() between memcached and couchbase sdk
[2:39pm] lachlan: Memcached::increment ( string $key [, int $offset = 1 [, int $initial_value = 0 [, int $expiry = 0 ]]] )
[2:39pm] lachlan: Couchbase - $object->increment($key [, $offset ] [, $create ] [, $expiry ] [, $initial ])
[2:39pm] trondn: hmm.. I guess that's a bug...
[2:40pm] trondn: let me file that one...
|Comment by Trond Norbye [ 16/Apr/13 ]|
|This will result in an API breakage... What should we do?|
|Comment by Matt Ingenthron [ 25/Sep/13 ]|
Brett: can you evaluate what we should do here?
Note that there is pecl/memcache and pecl/memcached. We've sort of copied the later and try to be somewhat API compatible, though there are clearly some constructor and error handling differences.
|Comment by Trond Norbye [ 25/Sep/13 ]|
|Changing the API will cause problems from others thats already using it :S|
|Comment by Brett Lawson [ 27/Sep/13 ]|
|I don't think changing this at this point is the best options, it will just confuse our existing users as Trond said. I think this is going to be something that was err'd on when the API was developed, that we may have to live with :) RFC!|