[PCBC-162] include_docs support missing Created: 11/Dec/12  Updated: 21/Jun/14  Resolved: 21/Jun/14

Status: Resolved
Project: Couchbase PHP client library
Component/s: library
Affects Version/s: None
Fix Version/s: None
Security Level: Public

Type: Bug Priority: Major
Reporter: Jeff Minard Assignee: Brett Lawson
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

viewopts.c appears to be missing include_docs as a valid parameter for the array values that get passed in for a view.

Comment by Jeff Minard [ 11/Dec/12 ]
I just added

# git diff
diff --git a/viewopts.c b/viewopts.c
index 612559d..4b9ce0f 100644
--- a/viewopts.c
+++ b/viewopts.c
@@ -54,6 +54,7 @@ static view_param Recognized_View_Params[] = {
        { "startkey", jval_param_handler },
        { "startkey_docid", string_param_handler },
        { "debug", bool_param_handler },
+ { "include_docs", bool_param_handler },
        { NULL, NULL }

And it seems to work just fine.
Comment by Brett Lawson [ 27/Sep/13 ]
Matt: Do you see any issue with adding include_docs as above, or should we be internally doing a batched get on the results.
Comment by Trond Norbye [ 30/Sep/13 ]
Include docs should not be passed to the server, but handled internally in the library fetching the documents over the data connection to the cluster.
Comment by Brett Lawson [ 21/Jun/14 ]
This issue does not present itself with the 2.0 SDKs.
Generated at Sun Nov 23 10:19:40 CST 2014 using JIRA 5.2.4#845-sha1:c9f4cc41abe72fb236945343a1f485c2c844dac9.