[MB-6990] User is able to save uncompilable map function for spatial view Created: 23/Oct/12  Updated: 12/Nov/12  Resolved: 24/Oct/12

Status: Closed
Project: Couchbase Server
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0
Security Level: Public

Type: Bug Priority: Major
Reporter: Iryna Mironava Assignee: Volker Mische
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment: centOS build 1884
<manifest><remote name="couchbase" fetch="git://10.1.1.210/"/><remote name="membase" fetch="git://10.1.1.210/"/><remote name="apache" fetch="git://github.com/apache/"/><remote name="erlang" fetch="git://github.com/erlang/"/><default remote="couchbase" revision="master"/><project name="tlm" path="tlm" revision="ab70f6d42f46621ec576889e57cb37ac2d64a84b"><copyfile dest="Makefile" src="Makefile.top"/></project><project name="bucket_engine" path="bucket_engine" revision="70b3624abc697b7d18bf3d57f331b7674544e1e7"/><project name="ep-engine" path="ep-engine" revision="6e2f6086abd905676f91ac6b20383f95012b8115"/><project name="libconflate" path="libconflate" revision="2cc8eff8e77d497d9f03a30fafaecb85280535d6"/><project name="libmemcached" path="libmemcached" revision="ca739a890349ac36dc79447e37da7caa9ae819f5" remote="membase"/><project name="libvbucket" path="libvbucket" revision="00d3763593c116e8e5d97aa0b646c42885727398"/><project name="membase-cli" path="membase-cli" revision="7fe4121e7e83952a4cb032e25a2cb9fca1709354" remote="membase"/><project name="memcached" path="memcached" revision="06ab906e6702917c4b6b90a6b0051644719a357d" remote="membase"/><project name="moxi" path="moxi" revision="52a5fa887bfff0bf719c4ee5f29634dd8707500e"/><project name="ns_server" path="ns_server" revision="5832be86eacab0be759201a2c0913589eac31c51"/><project name="portsigar" path="portsigar" revision="1bc865e1622fb93a3fe0d1a4cdf18eb97ed9d600"/><project name="sigar" path="sigar" revision="63a3cd1b316d2d4aa6dd31ce8fc66101b983e0b0"/><project name="couchbase-examples" path="couchbase-examples" revision="21e6161a1d064979b5c6aa99cd34ccc41c9d7aca"/><project name="couchbase-python-client" path="couchbase-python-client" revision="86b398e4fbc1f2e38d356e14df0c1bb4e3d2427b"/><project name="couchdb" path="couchdb" revision="33f201e8de269999f0aef3ea292fb5b0bdee97fe"/><project name="couchdbx-app" path="couchdbx-app" revision="76d79be79c1454cff0f878d5a88a792270ec1b17"/><project name="couchstore" path="couchstore" revision="d0e70d0dece8e4f4d0a782f4ac5452509fb3919b"/><project name="geocouch" path="geocouch" revision="da60ca707ad663074df85755ccb193f065fbfb5b"/><project name="mccouch" path="mccouch" revision="88701cc326bc3dde4ed072bb8441be83adcfb2a5"/><project name="testrunner" path="testrunner" revision="dbf7c1d6400393aa0b55ef9a584954d2f27387eb"/><project name="otp" path="otp" revision="b6dc1a844eab061d0a7153d46e7e68296f15a504" remote="erlang"/><project name="icu4c" path="icu4c" revision="26359393672c378f41f2103a8699c4357c894be7" remote="couchbase"/><project name="snappy" path="snappy" revision="5681dde156e9d07adbeeab79666c9a9d7a10ec95" remote="couchbase"/><project name="v8" path="v8" revision="447decb75060a106131ab4de934bcc374648e7f2" remote="couchbase"/><project name="gperftools" path="gperftools" revision="8f60ba949fb8576c530ef4be148bff97106ddc59" remote="couchbase"/><project name="pysqlite" path="pysqlite" revision="0ff6e32ea05037fddef1eb41a648f2a2141009ea" remote="couchbase"/></manifest>


 Description   
putting
{"views":{"df":{"map":"function (doc, meta) {\n emit(meta.id, null);\n}"}},"spatial":{"ff":"function (doc) {\n if (doc.geometry) {\n emit(doc.geometry, null);\n\n"}} (2 curlies are missing in map fn)
do not return any error

response is
{"ok":true,"id":"_design/dev_d"}

 Comments   
Comment by Farshid Ghods (Inactive) [ 23/Oct/12 ]
Volker,

please assign the ticket back to Alk if its UI related
Comment by Filipe Manana [ 23/Oct/12 ]
Yep. This is exactly what used to happen with the mapreduce engine and old couchdb view engine.
We haven't done many things for the geocouch engine, and until it's more unified with the other view engine, it will likely remain like that.

That will be post 2.0.
Comment by Volker Mische [ 23/Oct/12 ]
I'll try to fix it with adding the validation.
Comment by Steve Yen [ 23/Oct/12 ]
changing priority to major
Comment by Volker Mische [ 23/Oct/12 ]
Ready for review:
http://review.couchbase.org/21890
http://review.couchbase.org/21891
Comment by Volker Mische [ 24/Oct/12 ]
Merged!
Comment by Thuan Nguyen [ 24/Oct/12 ]
Integrated in github-couchdb-preview #524 (See [http://qa.hq.northscale.net/job/github-couchdb-preview/524/])
    MB-6990: Add validation of the spatial function (Revision ebe5a3ac0b35ae5c6d75954836b1ff2ddbfb34a5)

     Result = SUCCESS
Farshid Ghods :
Files :
* src/couchdb/couch_db.erl
Comment by Thuan Nguyen [ 25/Oct/12 ]
Integrated in github-couchdb-preview #525 (See [http://qa.hq.northscale.net/job/github-couchdb-preview/525/])
    MB-6990 Ignore missing module during make check (Revision ab2b0c230bffb74fcb3771db5871322c8ac806d0)

     Result = SUCCESS
steve :
Files :
* src/couchdb/couch_db.erl
Comment by Iryna Mironava [ 26/Oct/12 ]
verified on 1901
MB-7029 opened
Comment by kzeller [ 12/Nov/12 ]
Added to RN: For geo/spatial indexes, which is an experimental
feature in Couchbase 2.0, we now provide validation
of spatial functions.
Generated at Wed Sep 17 01:27:52 CDT 2014 using JIRA 5.2.4#845-sha1:c9f4cc41abe72fb236945343a1f485c2c844dac9.