[MB-6632] XDCR: ep_engine should be able to process a new_checkpoint command and notify this event to the external components. Created: 12/Sep/12  Updated: 17/Sep/12  Resolved: 12/Sep/12

Status: Resolved
Project: Couchbase Server
Component/s: couchbase-bucket, cross-datacenter-replication
Affects Version/s: 2.0-beta-2
Fix Version/s: 2.0
Security Level: Public

Type: Improvement Priority: Critical
Reporter: Junyi Xie Assignee: Chiyoung Seo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   
In effort to fix MB-6619, we change the ensure_full_commit from actively polling ep_engine stats during checkpointing, to event notification manner that it only gets notified when the checkpoint id changes. Today mc_connection:do_notify_vbucket_update() push event to event manager whenever the vbstate changes, which covers much more than checkpoint ID change. To avoid overhead to parse a large amount of unwanted msg from event manager, ep_engine need to provides a boolean flag to indicate that in this event, the checkpoint ID changes or not. Then we can filter out all other events involving no checkpoint change.

This may involves a protocol change between ep_engine and ns_server, commits on both sides need to be merged at the same time.

 Comments   
Comment by Chiyoung Seo [ 12/Sep/12 ]
http://review.couchbase.org/#/c/20810/
Comment by Thuan Nguyen [ 17/Sep/12 ]
Integrated in github-ep-engine-2-0 #430 (See [http://qa.hq.northscale.net/job/github-ep-engine-2-0/430/])
    MB-6632 Schedule vb state snapshot task for checkpoint changes (Revision ac6c438d35cb433d30c139cc48266188e738c350)
MB-6632 Extend couch_notification msg to notify checkpoint changes (Revision 245d4b85e9953cf41097262a37b2ce95eb451542)
MB-6632 Create a new checkpoint even if the current one is empty (Revision febc5e905e30bf2ae5c42654cfc89b94cc90c58f)

     Result = SUCCESS
Chiyoung Seo :
Files :
* src/ep.cc

Chiyoung Seo :
Files :
* src/couch-kvstore/couch-kvstore.cc
* src/couch-kvstore/couch-kvstore.hh
* src/couch-kvstore/couch-notifier.hh
* src/couch-kvstore/couch-notifier.cc

Chiyoung Seo :
Files :
* src/checkpoint.cc
Generated at Sat May 18 22:46:31 CDT 2013 using JIRA 5.2.4#845-sha1:c9f4cc41abe72fb236945343a1f485c2c844dac9.