[MB-5025] flush should return an error until such a time as it works Created: 06/Apr/12 Updated: 13/Jun/12 Resolved: 23/May/12 |
|
| Status: | Resolved |
| Project: | Couchbase Server |
| Component/s: | couchbase-bucket |
| Affects Version/s: | 1.7.2, 1.8.0, 2.0-developer-preview-3, 2.0-developer-preview-4 |
| Fix Version/s: | 1.8.1 |
| Security Level: | Public |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Matt Ingenthron | Assignee: | Junyi Xie |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 1.8.1-release-notes | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Until such a time as flush works, it should return an error. Optionally, flush should be enabled through cbflushctl in order to support testing with small datasets.
See also: |
| Comments |
| Comment by Matt Ingenthron [ 06/Apr/12 ] |
| Assigning to Frank for triage. |
| Comment by Steve Yen [ 11/Apr/12 ] |
| assigning to Dipti for a faster decision on this |
| Comment by Matt Ingenthron [ 18/Apr/12 ] |
| decision is to disable flush_all for 1.8.1 and provide a method for enabling it |
| Comment by Junyi Xie [ 18/Apr/12 ] |
|
Fix submitted to Gerrit at link:
http://review.couchbase.org/#change,15002 under code review. |
| Comment by Steve Yen [ 19/Apr/12 ] |
| moxi needs a test against this, as I'm not sure moxi expects an error from flush_all. |
| Comment by Junyi Xie [ 19/Apr/12 ] |
|
Hi Steve,
We have already merged the change set. Can you please elaborate how to test moxi against this change set? Thanks, Junyi |
| Comment by Junyi Xie [ 19/Apr/12 ] |
| http://review.couchbase.org/#change,15002 |
| Comment by Junyi Xie [ 26/Apr/12 ] |
|
Hi Dipti,
To enable flushall, you can add this in your the engine parameter file "flushall_enabled=true" To turn it off, you just need to remove this line. The default is off. Thanks. Junyi |
| Comment by Sharon Barr [ 26/Apr/12 ] |
|
We need to document that we need to enable it on each node separately .
Engine parameters are not a "cluster" parameters. |
| Comment by Thuan Nguyen [ 26/Apr/12 ] |
|
Integrated in github-ep-engine-2-0 #262 (See [http://qa.hq.northscale.net/job/github-ep-engine-2-0/262/]) Result = SUCCESS Junyi Xie : Files : * ep_engine.cc * ep_testsuite.cc * docs/engine-params.org * ep_engine.h * Makefile.am * configuration.json |
| Comment by Perry Krug [ 17/May/12 ] |
|
Has this not yet been merged into a build? I am unable to toggle the flush_all command with build 789:
[root@localhost ~]# /opt/couchbase/bin/cbflushctl localhost:11210 set flushall_enabled true setting flush param: flushall_enabled true Traceback (most recent call last): File "/opt/couchbase/lib/python/cbflushctl", line 87, in ? c.execute() File "/opt/couchbase/lib/python/clitool.py", line 43, in execute f[0](mc, *args[2:], **opts.__dict__) File "/opt/couchbase/lib/python/cbflushctl", line 42, in set_param mc.set_flush_param(key, val) File "/opt/couchbase/lib/python/mc_bin_client.py", line 214, in set_flush_param return self._doCmd(memcacheConstants.CMD_SET_FLUSH_PARAM, key, val) File "/opt/couchbase/lib/python/mc_bin_client.py", line 104, in _doCmd return self._handleSingleResponse(opaque) File "/opt/couchbase/lib/python/mc_bin_client.py", line 97, in _handleSingleResponse cmd, opaque, cas, keylen, extralen, data = self._handleKeyedResponse(myopaque) File "/opt/couchbase/lib/python/mc_bin_client.py", line 93, in _handleKeyedResponse raise MemcachedError(errcode, rv) mc_bin_client.MemcachedError: Memcached error #1: Unknown config param [root@localhost ~]# |
| Comment by Junyi Xie [ 23/May/12 ] |
|
Hi Dipiti,
The fix has been merged to 1.8.1 as CBD-152. http://review.couchbase.org/#change,16283 Let me close this bug if it is ok with you. Thanks Junyi |
| Comment by Junyi Xie [ 23/May/12 ] |
| http://review.couchbase.org/#change,16283 |