[CCBC-107] Handle stale/already sent pending commands on network error Created: 04/Oct/12  Updated: 21/Nov/12  Resolved: 19/Nov/12

Status: Closed
Project: Couchbase C client library libcouchbase
Component/s: None
Affects Version/s: 2.0.0beta
Fix Version/s: 2.0.0beta3
Security Level: Public

Type: Improvement Priority: Blocker
Reporter: Mark Nunberg Assignee: Mark Nunberg
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   
http://review.couchbase.org/13667

 Comments   
Comment by Sergey Avseyev [ 13/Nov/12 ]
what is stale command? libcouchbase doesn't have timeout per each command, so if server required to respond, but doesn't do it -- it is server bug. from other hand, if socket looks like dead, we are using timeout to purge requests
Comment by Matt Ingenthron [ 14/Nov/12 ]
Mark: Do you believe this needs to be addressed before 2.0 GA? If so, please drop in a note with the details.

My current read on this is that it's not really needed.
Comment by Sergey Avseyev [ 15/Nov/12 ]
Putting explicit link to test case http://review.couchbase.org/#/c/13667/12/tests/smoke-test.c
Comment by Matt Ingenthron [ 15/Nov/12 ]
Sergey: please extract the test in the referenced patchset and get it correct. Then, please update this issue with any findings from running that test. We'll see from there whether or not to keep it as a blocker.

I do agree that if operations timeout, that's okay when the connection is interrupted.
Comment by Sergey Avseyev [ 19/Nov/12 ]
The test has been ported to recent libcouchbase http://review.couchbase.org/22585 and currently it is passing
Comment by Sergey Avseyev [ 19/Nov/12 ]
Resolving the ticket, because the unit test from that patch is passing on recent version
Generated at Wed May 22 22:43:06 CDT 2013 using JIRA 5.2.4#845-sha1:c9f4cc41abe72fb236945343a1f485c2c844dac9.