Spy 132: AbstractLogger should be doing more level checks

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Won't Fix
Affects Version/s: 2.8.0-dp
Fix Version/s: 2.7.2
Component/s: None
Security Level: Public
Labels:
None

Description

Check in this patch.

http://code.google.com/p/spymemcached/issues/detail?id=132&colspec=stars%20id%20Milestone%20Priority%20Status%20Summary

Activity

Ascending order - Click to sort in descending order

Mike Wiederhold made changes - 06/Sep/11 7:39 PM

Field	Original Value	New Value
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Mike Wiederhold made changes - 07/Sep/11 2:52 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Mike Wiederhold added a comment - 07/Sep/11 2:52 PM

From Matt,

"on further thought, I am pretty sure the right answer here is don't do this at this level. We should change it in spy's default logger, but we want logger implementations to be somewhat in control over what gets logged, not us. We want to just send it up with the level we think makes sense. If they do something dynamic and we're doing something dynamic, there's too much dynamicism."

Show

Mike Wiederhold added a comment - 07/Sep/11 2:52 PM From Matt, "on further thought, I am pretty sure the right answer here is don't do this at this level. We should change it in spy's default logger, but we want logger implementations to be somewhat in control over what gets logged, not us. We want to just send it up with the level we think makes sense. If they do something dynamic and we're doing something dynamic, there's too much dynamicism."

Mike Wiederhold made changes - 07/Sep/11 2:52 PM