Hide
added a comment -
From Matt,
"on further thought, I am pretty sure the right answer here is don't do this at this level. We should change it in spy's default logger, but we want logger implementations to be somewhat in control over what gets logged, not us. We want to just send it up with the level we think makes sense. If they do something dynamic and we're doing something dynamic, there's too much dynamicism."
Show
added a comment - From Matt,
"on further thought, I am pretty sure the right answer here is don't do this at this level. We should change it in spy's default logger, but we want logger implementations to be somewhat in control over what gets logged, not us. We want to just send it up with the level we think makes sense. If they do something dynamic and we're doing something dynamic, there's too much dynamicism."
Bug
Closed
Major
"on further thought, I am pretty sure the right answer here is don't do this at this level. We should change it in spy's default logger, but we want logger implementations to be somewhat in control over what gets logged, not us. We want to just send it up with the level we think makes sense. If they do something dynamic and we're doing something dynamic, there's too much dynamicism."