Using Yajl json_gem compatibility breaks compatibility with many gems and applications

Sergey Avseyev added a comment - 10/May/12 1:42 AM Thanks for feedback, Does it make situation better if I'll use https://github.com/intridea/multi_json ?

Ben Poweski added a comment - 10/May/12 10:59 AM MultiJson would be better than using json_gem compatibility (Rails uses mulit_json to abstract json parsers). In this case though I don't think you even need to pull that dependency. If you just use Yajl::Parser and Yajl::Encoder directly you can skirt the entire problem. If you look at the the json_gem.rb file it really doesn't provide much functionality.   def self.generate(obj, opts={})     begin       options_map = {}       if opts.has_key?(:indent)         options_map[:pretty] = true         options_map[:indent] = opts[:indent]       end       Yajl::Encoder.encode(obj, options_map)     rescue Yajl::EncodeError => e       raise JSON::GeneratorError, e.message     end   end   def self.pretty_generate(obj, opts={})     begin       options_map = {}       options_map[:pretty] = true       options_map[:indent] = opts[:indent] if opts.has_key?(:indent)       Yajl::Encoder.encode(obj, options_map)     rescue Yajl::EncodeError => e       raise JSON::GeneratorError, e.message     end   end   def self.dump(obj, io=nil, *args)     begin       Yajl::Encoder.encode(obj, io)     rescue Yajl::EncodeError => e       raise JSON::GeneratorError, e.message     end   end

Sergey Avseyev added a comment - 17/May/12 6:18 PM Uploaded to review site http://review.couchbase.org/16153

Ben Poweski added a comment - 24/May/12 6:04 PM There is special handing for the json gem in rails thus breaking capability when the json_gem file is loaded after rails is https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/object/to_json.rb We worked around the issue by requiring yajl/json_gem before loading actives active support but this could have very well unknowingly break the driver.

Sergey Avseyev added a comment - 25/May/12 1:12 AM Now couchbase gem depends on only MultiJson and uses dump/load everywhere. Could you check current master version from github?