Details
-
Type:
Task
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: library
-
Security Level: Public
-
Labels:None
-
Environment:php-ext-couchbase git master @9a301ada0bf7
Description
In views.c in php_couchbase_view_impl(), the couchbase_res->rc result code is last set in case the lcb_timer can't be created. But it is not set in case of any further failures in actually processing the view results.
I expect it to clear the flag (set it to LCB_SUCCESS) on success, and set it to some meaningful error code in the failure branches:
https://github.com/couchbase/php-ext-couchbase/blob/cf70968ed3f0c781e75e4cc43de6c561019b459d/views.c#L357
https://github.com/couchbase/php-ext-couchbase/blob/cf70968ed3f0c781e75e4cc43de6c561019b459d/views.c#L369
I expect it to clear the flag (set it to LCB_SUCCESS) on success, and set it to some meaningful error code in the failure branches:
https://github.com/couchbase/php-ext-couchbase/blob/cf70968ed3f0c781e75e4cc43de6c561019b459d/views.c#L357
https://github.com/couchbase/php-ext-couchbase/blob/cf70968ed3f0c781e75e4cc43de6c561019b459d/views.c#L369
Activity
- All
- Comments
- Work Log
- History
- Activity
- Gerrit Reviews
Tim Smith
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Planned Start | 2013-02-18 12:00 (initialized without having effort estimation) | |
| Planned End | 2013-02-18 12:00 (initialized without having effort estimation) |
Trond Norbye
made changes -
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] |