Couchbase PHP client library

Segmentation Fault (segfault) when querying view

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.1.0-dp5
  • Fix Version/s: 1.1.0
  • Component/s: library
  • Security Level: Public
  • Labels:
    None
  • Environment:
    PHP 5.3.13 / 5.3.15, Redhat 5.6

Description

When doing a query against a view, the php application segfaults. Set/get/delete commands all work fine.

Attached is an strace, a stack trace from gdb, and various other support files, including the repro script.
  1. File
    cbt.php
    15/Nov/12 3:58 PM
    0.2 kB
    Jeff Minard
  2. Text File
    gdb.txt
    15/Nov/12 4:03 PM
    0.9 kB
    Jeff Minard
  3. Text File
    gdb-bt.txt
    15/Nov/12 4:12 PM
    1 kB
    Jeff Minard
  4. Text File
    gdb-bt-git.txt
    15/Nov/12 4:15 PM
    1 kB
    Jeff Minard
  5. Text File
    php-m-i.txt
    15/Nov/12 3:58 PM
    0.8 kB
    Jeff Minard
  6. Text File
    strace.txt
    15/Nov/12 3:58 PM
    88 kB
    Jeff Minard

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeff Minard added a comment -
I was asked to run a gdb, but I don't really think it looks that helpful. I've attached it.
Show
Jeff Minard added a comment - I was asked to run a gdb, but I don't really think it looks that helpful. I've attached it.
Hide
Permalink
Jeff Minard added a comment -
gdb file, looks pretty useless without a php debug symbols version
Show
Jeff Minard added a comment - gdb file, looks pretty useless without a php debug symbols version
Jeff Minard made changes -
Field Original Value New Value
Attachment gdb.txt [ 15825 ]
Hide
Permalink
Mark Nunberg added a comment - - edited
My bad. Type 'bt' when you get the segfault :)

That'll show you the stack trace
Show
Mark Nunberg added a comment - - edited My bad. Type 'bt' when you get the segfault :) That'll show you the stack trace
Hide
Permalink
Jeff Minard added a comment -
Yes, this looks much more helpful :)
Show
Jeff Minard added a comment - Yes, this looks much more helpful :)
Jeff Minard made changes -
Attachment gdb-bt.txt [ 15826 ]
Hide
Permalink
Jeff Minard added a comment -
Here is the same segfault when using the latest couchbase.so compiled from the github master branch (so, cutting edge, I'd seen some lcb changes, so I figured I'd give ya both).
Show
Jeff Minard added a comment - Here is the same segfault when using the latest couchbase.so compiled from the github master branch (so, cutting edge, I'd seen some lcb changes, so I figured I'd give ya both).
Jeff Minard made changes -
Attachment gdb-bt-git.txt [ 15827 ]
Hide
Permalink
Mark Nunberg added a comment -
Can you try this patch?

diff --git a/views.c b/views.c
index 6c7bc30..7d03c5a 100644
--- a/views.c
+++ b/views.c
@@ -52,12 +52,13 @@ void php_couchbase_complete_callback(lcb_http_request_t request,
                return;
        }
 
+ /** We have one extra byte in 'data' */
        hti = emalloc(sizeof(*hti) + resp->v.v0.nbytes);
        hti->ndata = resp->v.v0.nbytes;
- memcpy(hti->data, resp->v.v0.bytes, hti->ndata + 1);
+
        if (hti->ndata) {
- hti->data[hti->ndata - 1] = '\0';
- hti->ndata--;
+ memcpy(hti->data, resp->v.v0.bytes, hti->ndata);
+ hti->data[hti->ndata] = '\0';
        }
 
        ctx->res->rc = error;

I'll make it as a gerrit changeset as well..
Show
Mark Nunberg added a comment - Can you try this patch? diff --git a/views.c b/views.c index 6c7bc30..7d03c5a 100644 --- a/views.c +++ b/views.c @@ -52,12 +52,13 @@ void php_couchbase_complete_callback(lcb_http_request_t request,                 return;         }   + /** We have one extra byte in 'data' */         hti = emalloc(sizeof(*hti) + resp->v.v0.nbytes);         hti->ndata = resp->v.v0.nbytes; - memcpy(hti->data, resp->v.v0.bytes, hti->ndata + 1); +         if (hti->ndata) { - hti->data[hti->ndata - 1] = '\0'; - hti->ndata--; + memcpy(hti->data, resp->v.v0.bytes, hti->ndata); + hti->data[hti->ndata] = '\0';         }           ctx->res->rc = error; I'll make it as a gerrit changeset as well..
Hide
Permalink
Mark Nunberg added a comment -
http://review.couchbase.org/22573
Show
Mark Nunberg added a comment - http://review.couchbase.org/22573
Hide
Permalink
Jeff Minard added a comment -
That changed fixed the segfault, yes. The value assigned to the variable from the $cb->view() call is bool(false)
Show
Jeff Minard added a comment - That changed fixed the segfault, yes. The value assigned to the variable from the $cb->view() call is bool(false)
Hide
Permalink
Matt Ingenthron added a comment -
Thanks for the quick work Mark! Looks like it'll be closeable after it's reviewed and in.
Show
Matt Ingenthron added a comment - Thanks for the quick work Mark! Looks like it'll be closeable after it's reviewed and in.
Matt Ingenthron made changes -
Assignee Matt Ingenthron [ ingenthr ] Mark Nunberg [ mnunberg ]
Trond Norbye made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.1.0 [ 10242 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Mark Nunberg
    Reporter:
    Jeff Minard
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: