Couchbase PHP client library

Provide more information on connection failure

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.5, 1.1.0-dp4
  • Fix Version/s: 1.0.6, 1.1.0
  • Component/s: library
  • Security Level: Public
  • Labels:
    None

Description

When you connect via the new Couchbase(...) is not a direct way to check for whether the connection failed.

It is not possible to check getResultCode()/getResultMessage() since this provides a unintilized couchbase

Issue Links

duplicates

Improvement - An improvement or enhancement to an existing feature or task. PCBC-58 Couchbase.so - constructing Couchbase() doesn't throw an exception on connection error

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark Nunberg added a comment -
For this we'd probably need to change the ext code to return a valid couchbase object so that getResultCode can be called on it (to check for connection failures).

For the non-oo variant (couchbase_connect) behavior should remain the same (?)

Additionally, all the code which now checks for the couchbase object to simply exist should be changed to check that the couchbase object is indeed connected (I believe lcb has a function for that, but if not we can set our own little flag in our php_couchbase_ctx structure).

One workaround is to call set_error_handler and make it throw an ErrorException right before instantiation. Then the connection can be done in a try/catch block, with any message being found in $ex->getMessage().

I believe there may be ther workarounds as well
Show
Mark Nunberg added a comment - For this we'd probably need to change the ext code to return a valid couchbase object so that getResultCode can be called on it (to check for connection failures). For the non-oo variant (couchbase_connect) behavior should remain the same (?) Additionally, all the code which now checks for the couchbase object to simply exist should be changed to check that the couchbase object is indeed connected (I believe lcb has a function for that, but if not we can set our own little flag in our php_couchbase_ctx structure). One workaround is to call set_error_handler and make it throw an ErrorException right before instantiation. Then the connection can be done in a try/catch block, with any message being found in $ex->getMessage(). I believe there may be ther workarounds as well
Hide
Permalink
Michael Jackson added a comment -
patch set in progress: http://review.couchbase.org/#/c/21433/
Show
Michael Jackson added a comment - patch set in progress: http://review.couchbase.org/#/c/21433/
Hide
Permalink
Michael Jackson added a comment -
As a side note, I have a 1.0.x backport of the changes above ready to roll once the master branch changes are approved/merged.
Show
Michael Jackson added a comment - As a side note, I have a 1.0.x backport of the changes above ready to roll once the master branch changes are approved/merged.
Hide
Permalink
Michael Jackson added a comment -
master branch changeset is merged in. 1.0.x changeset is here: http://review.couchbase.org/#/c/21487/
Show
Michael Jackson added a comment - master branch changeset is merged in. 1.0.x changeset is here: http://review.couchbase.org/#/c/21487/
Hide
Permalink
Michael Jackson added a comment -
(I believe all this needs for resolution is the 1.0.x changeset mentioned above to be merged into 1.0.x branch.)
Show
Michael Jackson added a comment - (I believe all this needs for resolution is the 1.0.x changeset mentioned above to be merged into 1.0.x branch.)
Hide
Permalink
Michael Jackson added a comment -
1.0.x merged in just now, 1.1 has been in for a bit. Should be present in next released versions.
Show
Michael Jackson added a comment - 1.0.x merged in just now, 1.1 has been in for a bit. Should be present in next released versions.

People

  • Assignee:
    Michael Jackson
    Reporter:
    Dan Andersen
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: