Couchbase Server

refine definition/use of ep_max_data_size and ep_max_size

Details

  • Type: Improvement Improvement
  • Status: Reopened Reopened
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: 2.1
  • Component/s: couchbase-bucket
  • Security Level: Public
  • Labels:
    None

Description

This is very minor but it appears to be that ep_max_data_size and ep_max_size represents basically the same value. However, ep_max_size has the value change listener for allowing change its value dynamically. Either remove one of stat if found to be redundant or re-define each stat and its use.

Also, it is probably a good idea to revisit our stats.org and find if there are any more redundant & intermingled case like this for another stats.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike Wiederhold added a comment -
http://review.couchbase.org/#/c/23849/
Show
Mike Wiederhold added a comment - http://review.couchbase.org/#/c/23849/
Hide
Permalink
Thuan Nguyen added a comment -
Integrated in github-ep-engine-2-0 #481 (See [http://qa.hq.northscale.net/job/github-ep-engine-2-0/481/])
    MB-7483: Remove duplicate stats holding bucket size (Revision 7e84fc9ce1488722e055a496382af302f655b417)
Revert "MB-7483: Remove duplicate stats holding bucket size" (Revision 2d14e9a818699e22b61e8b837280d1fafb3120bc)

     Result = SUCCESS
Mike Wiederhold :
Files :
* src/ep_engine.cc
* tests/ep_testsuite.cc
* docs/stats.org

Mike Wiederhold :
Files :
* tests/ep_testsuite.cc
* src/ep_engine.cc
* docs/stats.org
Show
Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #481 (See [ http://qa.hq.northscale.net/job/github-ep-engine-2-0/481/ ])      MB-7483 : Remove duplicate stats holding bucket size (Revision 7e84fc9ce1488722e055a496382af302f655b417) Revert " MB-7483 : Remove duplicate stats holding bucket size" (Revision 2d14e9a818699e22b61e8b837280d1fafb3120bc)      Result = SUCCESS Mike Wiederhold : Files : * src/ep_engine.cc * tests/ep_testsuite.cc * docs/stats.org Mike Wiederhold : Files : * tests/ep_testsuite.cc * src/ep_engine.cc * docs/stats.org
Hide
Permalink
Maria McDuff added a comment -
shashank, pls verify. thanks.
to verify (per mike), , telnet in and get stats. You should make sure there are no duplicate stats
Show
Maria McDuff added a comment - shashank, pls verify. thanks. to verify (per mike), , telnet in and get stats. You should make sure there are no duplicate stats
Hide
Permalink
Shashank Gupta added a comment -
Collected the stats for a single bucket and both are showing the same results.

 ep_max_size: 1073741824

 ep_max_data_size: 1073741824

Used the build 2.0.2-761-rel.
Show
Shashank Gupta added a comment - Collected the stats for a single bucket and both are showing the same results.  ep_max_size: 1073741824  ep_max_data_size: 1073741824 Used the build 2.0.2-761-rel.
Hide
Permalink
Deepkaran Salooja added a comment -
Looking at the gerrit, ep_max_data_size should no longer be there.

Mike, can you please confirm if both these stats should still be there?
Show
Deepkaran Salooja added a comment - Looking at the gerrit, ep_max_data_size should no longer be there. Mike, can you please confirm if both these stats should still be there?
Hide
Permalink
Mike Wiederhold added a comment -
This change was reverted. I will fix it in 2.1.
Show
Mike Wiederhold added a comment - This change was reverted. I will fix it in 2.1.

People

  • Assignee:
    Mike Wiederhold
    Reporter:
    Jin Lim
Vote (0)
Watch (5)

Dates

  • Created:
    Updated: