moxi crashes when doing a mget with a key size exceeding 250 characters

Bala Keelapudi added a comment - 05/Dec/12 1:20 AM // Multi-key GET/GETS. > // > // We should keep processing for a non-quiet > // terminating response (NO-OP). > // > conn_set_state(c, conn_new_cmd); > > if (status != 0) { > assert(it == NULL); > > if (status == PROTOCOL_BINARY_RESPONSE_KEY_ENOENT) { > return; // Swallow miss response. > } > > // TODO: Handle error case. Should we pause the conn > // or keep looking for more responses? > // > assert(false); // <--- THIS IS LINE 774, REFERRED ON THE ERROR MESSAGE :GFERNANDEZ > return; > } >

Steve Yen added a comment - 10/Dec/12 6:42 PM Hi Ronnie, Got a C fix for you. Can you take a look at a moxi fix? Thanks, Steve

Farshid Ghods added a comment - 09/Jan/13 8:16 PM per bug scrub - deferring this to 2.0.2

Ronnie Sun added a comment - 13/Mar/13 1:24 PM Tried with 2.0.1 build and the latest moxi checkout. Cannot reproduce this issue. Investigations as follows: - When issuing an ascii multiget command by supplying a single invalid key (key_len > 250), moxi simply returned an 'END' - When issuing an ascii multiget command by supplying a mixed of valid and invalid keys, moxi returned results for valid ones and bypassed the invalids. (Actually the binary downstream returned NOOP for these invalid keys, moxi then released the connection resources.) - Tried 10000 ops, moxi did not crash. Command used: MemcachedAsciiClient.getMulti(["aaa","abcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghiabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijabcdefghijj", "bbb"])

Maria McDuff added a comment - 05/Apr/13 3:04 AM abhinav, pls check if this is still happening in current 2.0.2 build. close if no longer an issue. thanks.

Maria McDuff added a comment - 15/Apr/13 1:38 PM unable to repro the crash. closing as fixed.