Couchbase Server

Fix UI to support Non-JSON values ( was: Non-JSON values which are not integers show up as base-64 encoded when viewed through the UI document viewer)

Details

  • Type: Improvement Improvement
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: .next
  • Component/s: ns_server
  • Security Level: Public

Description

Reproduction:
-Set a key with some non-JSON value
-View that key through the document viewer in the UI
-See that the value does not match what was just set

I presume this is because we are compressing the data at the disk level and then reading that binary attachment back when viewing through the UI...but it's quite confusing for the user to not be able to see what they thought was simple string data.

Does this at all affect views of non-JSON (i.e., increment counters)? Even in the random doc preview, this data does not come across correctly...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chiyoung Seo added a comment -
Farshid,

Please assign this bug to the view or UI team. ep-engine has nothing to do with view and its UI.
Show
Chiyoung Seo added a comment - Farshid, Please assign this bug to the view or UI team. ep-engine has nothing to do with view and its UI.
Hide
Permalink
Farshid Ghods added a comment -
Perry,

can you please specify whether the document was an ascii or a binary data ?
Show
Farshid Ghods added a comment - Perry, can you please specify whether the document was an ascii or a binary data ?
Hide
Permalink
Perry Krug added a comment -
Ascii. I tried both a few characters in string and a single integer value (as if it were an increment counter value).

This came up from a customer who created a CSV list and wanted to view it through the UI as well as design a view around it.

I'm fairly certain the problem is that this mechanism for viewing documents is coming directly from the on-disk datastore (as opposed to through memcached) and therefore it is compressed binary and not exactly what the application put in.

Let me know if you need more specific reproduction details.
Show
Perry Krug added a comment - Ascii. I tried both a few characters in string and a single integer value (as if it were an increment counter value). This came up from a customer who created a CSV list and wanted to view it through the UI as well as design a view around it. I'm fairly certain the problem is that this mechanism for viewing documents is coming directly from the on-disk datastore (as opposed to through memcached) and therefore it is compressed binary and not exactly what the application put in. Let me know if you need more specific reproduction details.
Hide
Permalink
Deepkaran Salooja added a comment -
Anything which doesn't parse as valid json are encoded as base64 and stored as an attachment. In the UI for document viewer these get displayed as binary.
There was a recent bug fix for the increment counter values. So string integers will show up fine as they now parse as valid JSONs(screenshot attached-StringNumbersAsValidJson). Please see MB-6961 for detailed discussion.
For normal strings, these will get displayed as binary(screenshot-StringAsNonJson).
Show
Deepkaran Salooja added a comment - Anything which doesn't parse as valid json are encoded as base64 and stored as an attachment. In the UI for document viewer these get displayed as binary. There was a recent bug fix for the increment counter values. So string integers will show up fine as they now parse as valid JSONs(screenshot attached-StringNumbersAsValidJson). Please see MB-6961 for detailed discussion. For normal strings, these will get displayed as binary(screenshot-StringAsNonJson).
Hide
Permalink
Farshid Ghods added a comment -
resolving this as won't fix since this is an expected behavior as mentioned in the last comment

the fix for this would be to reverse the base64 coding ?
Show
Farshid Ghods added a comment - resolving this as won't fix since this is an expected behavior as mentioned in the last comment the fix for this would be to reverse the base64 coding ?
Hide
Permalink
Farshid Ghods added a comment -
for 2.0 i marked this to be documented since our documented editing section is not meant for non-json values ( e.g http://www.couchbase.com/issues/browse/MB-7031)
Show
Farshid Ghods added a comment - for 2.0 i marked this to be documented since our documented editing section is not meant for non-json values ( e.g http://www.couchbase.com/issues/browse/MB-7031)
Hide
Permalink
Perry Krug added a comment -
Sorry if it should be obvious...but this is already fixed in a later release and so just have to document for the beta? Or is it planned for this never to be supported?

Thanks Farshid
Show
Perry Krug added a comment - Sorry if it should be obvious...but this is already fixed in a later release and so just have to document for the beta? Or is it planned for this never to be supported? Thanks Farshid
Hide
Permalink
Farshid Ghods added a comment -
>>.but this is already fixed in a later release
viewing non-json values on document editing page is not supported or expected behavior.
however as Deep mentioned a corner case is fixed in MB-6961

once 7031 is merged ( before 2.0 GA ) user will see a better error message when document is non-json

so for 2.0 GA we need to document that this behavior is not supported and expected.

Show
Farshid Ghods added a comment - >>.but this is already fixed in a later release viewing non-json values on document editing page is not supported or expected behavior. however as Deep mentioned a corner case is fixed in MB-6961 once 7031 is merged ( before 2.0 GA ) user will see a better error message when document is non-json so for 2.0 GA we need to document that this behavior is not supported and expected.
Hide
Permalink
Perry Krug added a comment -
Okay, I might need to question that a little bit...how is a user supposed to write a view around a non-JSON (i.e. an incremement counter or CSV) if they can't see it in the document viewer? Writing such views is supposed to be supported right? Seems like this would have to be as well?

Obviously document it for whenever we can't, but I think Dipti needs to decide how to address it.
Show
Perry Krug added a comment - Okay, I might need to question that a little bit...how is a user supposed to write a view around a non-JSON (i.e. an incremement counter or CSV) if they can't see it in the document viewer? Writing such views is supposed to be supported right? Seems like this would have to be as well? Obviously document it for whenever we can't, but I think Dipti needs to decide how to address it.
Hide
Permalink
MC Brown added a comment -
Note has been added to the corresponding section of the docs,and to the release notes.
Show
MC Brown added a comment - Note has been added to the corresponding section of the docs,and to the release notes.
Hide
Permalink
Perry Krug added a comment -
Reopening as it's still not clear whether this is something we want to support or not...and I argue that we should.
Show
Perry Krug added a comment - Reopening as it's still not clear whether this is something we want to support or not...and I argue that we should.
Hide
Permalink
Dipti Borkar added a comment -
The UI does not handle BLOB data very well. Data access using the APIs for BLOBs is completely supported and works well.
Show
Dipti Borkar added a comment - The UI does not handle BLOB data very well. Data access using the APIs for BLOBs is completely supported and works well.
Hide
Permalink
Karen Zeller added a comment -
Removing docs tag, additional server work required. Reassign when ready to document post-resolution.
Show
Karen Zeller added a comment - Removing docs tag, additional server work required. Reassign when ready to document post-resolution.

People

  • Assignee:
    Aleksey Kondratenko
    Reporter:
    Perry Krug
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: