Couchbase Server

flush should return an error until such a time as it works

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.7.2, 1.8.0, 2.0-developer-preview-3, 2.0-developer-preview-4
  • Fix Version/s: 1.8.1
  • Component/s: couchbase-bucket
  • Security Level: Public

Description

Until such a time as flush works, it should return an error. Optionally, flush should be enabled through cbflushctl in order to support testing with small datasets.

See also:
MB-4717 and MB-4601

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Ingenthron added a comment -
Assigning to Frank for triage.
Show
Matt Ingenthron added a comment - Assigning to Frank for triage.
Matt Ingenthron made changes -
Field Original Value New Value
Assignee Frank Weigel [ frank ]
Matt Ingenthron made changes -
Description Until such a time as flush works, it should return an error. Ideally, with some configuration option to turn it back on for testing with small datasets. Until such a time as flush works, it should return an error. Ideally, with some configuration option to turn it back on for testing with small datasets.

See also:
MB-4717 and MB-4601
Dipti Borkar made changes -
Labels next_sprint
Dipti Borkar made changes -
Labels next_sprint current_sprint
Dipti Borkar made changes -
Labels current_sprint next_sprint
Dipti Borkar made changes -
Sprint Priority 10
Farshid Ghods made changes -
Component/s couchbase-bucket [ 10173 ]
Component/s ep_engine [ 10013 ]
Hide
Permalink
Steve Yen added a comment -
assigning to Dipti for a faster decision on this
Show
Steve Yen added a comment - assigning to Dipti for a faster decision on this
Steve Yen made changes -
Assignee Frank Weigel [ frank ] Dipti Borkar [ dipti ]
Dipti Borkar made changes -
Assignee Dipti Borkar [ dipti ] Chiyoung Seo [ chiyoung ]
Chiyoung Seo made changes -
Sprint Status Current Sprint
Story Points 1
Chiyoung Seo made changes -
Labels next_sprint
Assignee Chiyoung Seo [ chiyoung ] Junyi Xie [ junyi ]
Description Until such a time as flush works, it should return an error. Ideally, with some configuration option to turn it back on for testing with small datasets.

See also:
MB-4717 and MB-4601 		Until such a time as flush works, it should return an error. Optionally, flush should be enabled through cbflushctl in order to support testing with small datasets.

See also:
MB-4717 and MB-4601
Sprint Priority 10 2
Hide
Permalink
Matt Ingenthron added a comment -
decision is to disable flush_all for 1.8.1 and provide a method for enabling it
Show
Matt Ingenthron added a comment - decision is to disable flush_all for 1.8.1 and provide a method for enabling it
Junyi Xie made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Junyi Xie added a comment -
Fix submitted to Gerrit at link:

http://review.couchbase.org/#change,15002

under code review.


Show
Junyi Xie added a comment - Fix submitted to Gerrit at link: http://review.couchbase.org/#change,15002 under code review.
Hide
Permalink
Steve Yen added a comment -
moxi needs a test against this, as I'm not sure moxi expects an error from flush_all.
Show
Steve Yen added a comment - moxi needs a test against this, as I'm not sure moxi expects an error from flush_all.
Hide
Permalink
Junyi Xie added a comment -
Hi Steve,
We have already merged the change set. Can you please elaborate how to test moxi against this change set?

Thanks,

Junyi
Show
Junyi Xie added a comment - Hi Steve, We have already merged the change set. Can you please elaborate how to test moxi against this change set? Thanks, Junyi
Hide
Permalink
Junyi Xie added a comment -
http://review.couchbase.org/#change,15002
Show
Junyi Xie added a comment - http://review.couchbase.org/#change,15002
Junyi Xie made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Junyi Xie added a comment -
Hi Dipti,

To enable flushall, you can add this in your the engine parameter file

"flushall_enabled=true"

To turn it off, you just need to remove this line. The default is off.

Thanks.

Junyi
Show
Junyi Xie added a comment - Hi Dipti, To enable flushall, you can add this in your the engine parameter file "flushall_enabled=true" To turn it off, you just need to remove this line. The default is off. Thanks. Junyi
Hide
Permalink
Sharon Barr added a comment -
We need to document that we need to enable it on each node separately .
Engine parameters are not a "cluster" parameters.
Show
Sharon Barr added a comment - We need to document that we need to enable it on each node separately . Engine parameters are not a "cluster" parameters.
Hide
Permalink
Thuan Nguyen added a comment -
Integrated in github-ep-engine-2-0 #262 (See [http://qa.hq.northscale.net/job/github-ep-engine-2-0/262/])
    MB-5025 disable flushall by default (Revision d9d123f4a54def7cf2cbaed6e0189d9b846002da)

     Result = SUCCESS
Junyi Xie :
Files :
* ep_engine.cc
* ep_testsuite.cc
* docs/engine-params.org
* ep_engine.h
* Makefile.am
* configuration.json
Show
Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #262 (See [ http://qa.hq.northscale.net/job/github-ep-engine-2-0/262/ ])      MB-5025 disable flushall by default (Revision d9d123f4a54def7cf2cbaed6e0189d9b846002da)      Result = SUCCESS Junyi Xie : Files : * ep_engine.cc * ep_testsuite.cc * docs/engine-params.org * ep_engine.h * Makefile.am * configuration.json
Dipti Borkar made changes -
Sprint Status Current Sprint
Dipti Borkar made changes -
Labels 1.8.1-release-notes
Hide
Permalink
Perry Krug added a comment -
Has this not yet been merged into a build? I am unable to toggle the flush_all command with build 789:

[root@localhost ~]# /opt/couchbase/bin/cbflushctl localhost:11210 set flushall_enabled true
setting flush param: flushall_enabled true
Traceback (most recent call last):
  File "/opt/couchbase/lib/python/cbflushctl", line 87, in ?
    c.execute()
  File "/opt/couchbase/lib/python/clitool.py", line 43, in execute
    f[0](mc, *args[2:], **opts.__dict__)
  File "/opt/couchbase/lib/python/cbflushctl", line 42, in set_param
    mc.set_flush_param(key, val)
  File "/opt/couchbase/lib/python/mc_bin_client.py", line 214, in set_flush_param
    return self._doCmd(memcacheConstants.CMD_SET_FLUSH_PARAM, key, val)
  File "/opt/couchbase/lib/python/mc_bin_client.py", line 104, in _doCmd
    return self._handleSingleResponse(opaque)
  File "/opt/couchbase/lib/python/mc_bin_client.py", line 97, in _handleSingleResponse
    cmd, opaque, cas, keylen, extralen, data = self._handleKeyedResponse(myopaque)
  File "/opt/couchbase/lib/python/mc_bin_client.py", line 93, in _handleKeyedResponse
    raise MemcachedError(errcode, rv)
mc_bin_client.MemcachedError: Memcached error #1: Unknown config param
[root@localhost ~]#
Show
Perry Krug added a comment - Has this not yet been merged into a build? I am unable to toggle the flush_all command with build 789: [ root@localhost ~]# /opt/couchbase/bin/cbflushctl localhost:11210 set flushall_enabled true setting flush param: flushall_enabled true Traceback (most recent call last):   File "/opt/couchbase/lib/python/cbflushctl", line 87, in ?     c.execute()   File "/opt/couchbase/lib/python/clitool.py", line 43, in execute     f[0](mc, *args[2:], **opts.__dict__)   File "/opt/couchbase/lib/python/cbflushctl", line 42, in set_param     mc.set_flush_param(key, val)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 214, in set_flush_param     return self._doCmd(memcacheConstants.CMD_SET_FLUSH_PARAM, key, val)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 104, in _doCmd     return self._handleSingleResponse(opaque)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 97, in _handleSingleResponse     cmd, opaque, cas, keylen, extralen, data = self._handleKeyedResponse(myopaque)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 93, in _handleKeyedResponse     raise MemcachedError(errcode, rv) mc_bin_client.MemcachedError: Memcached error #1: Unknown config param [ root@localhost ~]#
Perry Krug made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Dipti Borkar made changes -
Comment [ A comment with security level 'Membase Inc' was removed. ]
Dipti Borkar made changes -
Sprint Status Current Sprint
Hide
Permalink
Junyi Xie added a comment -
Hi Dipiti,

The fix has been merged to 1.8.1 as CBD-152.

http://review.couchbase.org/#change,16283

Let me close this bug if it is ok with you.

Thanks

Junyi
Show
Junyi Xie added a comment - Hi Dipiti, The fix has been merged to 1.8.1 as CBD-152. http://review.couchbase.org/#change,16283 Let me close this bug if it is ok with you. Thanks Junyi
Hide
Permalink
Junyi Xie added a comment -
http://review.couchbase.org/#change,16283
Show
Junyi Xie added a comment - http://review.couchbase.org/#change,16283
Junyi Xie made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Chiyoung Seo made changes -
Sprint Status Current Sprint
MC Brown made changes -
Comment [ Lu provided by the 09 series in a warm summer morning coastline, <strong><a href="http://www.replicawatchesale1.com/">Replica Rolex</a></strong> think. Surprisingly, the temperature, one mile one mile natural sand, <strong><a href="http://www.popreplicabags.com/">Replica Handbags</a></strong> part of the vast expanse of water, heat the coast of the pie, Ipanema beach on the beautiful landscape diversity. We will conduct our bathing suits, sunglasses, bags, bracelets, links ... <strong><a href="http://www.popreplicabags.com/">Louis Vuitton Handbags</a></strong> whatever you bring you to enjoy your glorious period. Of course, <strong><a href="http://www.popreplicabags.com/louis-vuitton-handbags-louis-vuitton-speedy-c-1_2_33.html">Louis Vuitton Speedy</a></strong> the most important commodity on the beach, so the need for frequent bag, we can easily invest in those clothes, as well as with spicy each of us demonstrators, Cabas the same time.Your of Ipanema Beach is the main function. very suitable for people who are looking for an exciting beach holiday. The popular and stylish, and definitely should never be a magnificent coastline. As the hot visual appeal, <strong><a href="http://www.popreplicabags.com/louis-vuitton-handbags-louis-vuitton-neverfull-c-1_2_34.html">Louis Vuitton Neverfull</a></strong> my wife and I almost Tahitienne series supervision concept! <strong><a href="http://www.popreplicabags.com/louis-vuitton-handbags-louis-vuitton-alma-c-1_2_35.html">Louis Vuitton Alma</a></strong> Seriously with these people may be very similar, while the spherical design.Take Beach Cabas Ipanema, <strong><a href="http://www.popreplicabags.com/louis-vuitton-handbags-louis-vuitton-artsy-c-1_2_36.html">Louis Vuitton Artsy</a></strong> a good form of advertising on the Internet. It's just an elegant open-air use of organic cotton bag material, logo, excellent color, fine pleated, tapered basic structure of the management of every detail, <strong><a href="http://www.popreplicabags.com/louis-vuitton-handbags-louis-vuitton-keepall-c-1_2_37.html">Louis Vuitton Keepall</a></strong> in full compliance with the occasion of your beach. ]

People

  • Assignee:
    Junyi Xie
    Reporter:
    Matt Ingenthron
Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: