flush should return an error until such a time as it works

Matt Ingenthron added a comment - 06/Apr/12 8:41 PM Assigning to Frank for triage.

Steve Yen added a comment - 11/Apr/12 11:24 AM assigning to Dipti for a faster decision on this

Matt Ingenthron added a comment - 18/Apr/12 2:45 AM decision is to disable flush_all for 1.8.1 and provide a method for enabling it

Junyi Xie added a comment - 18/Apr/12 8:09 PM Fix submitted to Gerrit at link: http://review.couchbase.org/#change,15002 under code review.

Steve Yen added a comment - 19/Apr/12 4:31 PM moxi needs a test against this, as I'm not sure moxi expects an error from flush_all.

Junyi Xie added a comment - 19/Apr/12 4:45 PM Hi Steve, We have already merged the change set. Can you please elaborate how to test moxi against this change set? Thanks, Junyi

Junyi Xie added a comment - 19/Apr/12 4:48 PM http://review.couchbase.org/#change,15002

Junyi Xie added a comment - 26/Apr/12 12:24 PM Hi Dipti, To enable flushall, you can add this in your the engine parameter file "flushall_enabled=true" To turn it off, you just need to remove this line. The default is off. Thanks. Junyi

Sharon Barr added a comment - 26/Apr/12 12:32 PM We need to document that we need to enable it on each node separately . Engine parameters are not a "cluster" parameters.

Thuan Nguyen added a comment - 26/Apr/12 7:54 PM Integrated in github-ep-engine-2-0 #262 (See [ http://qa.hq.northscale.net/job/github-ep-engine-2-0/262/ ])      MB-5025 disable flushall by default (Revision d9d123f4a54def7cf2cbaed6e0189d9b846002da)      Result = SUCCESS Junyi Xie : Files : * ep_engine.cc * ep_testsuite.cc * docs/engine-params.org * ep_engine.h * Makefile.am * configuration.json

Perry Krug added a comment - 17/May/12 1:40 PM Has this not yet been merged into a build? I am unable to toggle the flush_all command with build 789: [ root@localhost ~]# /opt/couchbase/bin/cbflushctl localhost:11210 set flushall_enabled true setting flush param: flushall_enabled true Traceback (most recent call last):   File "/opt/couchbase/lib/python/cbflushctl", line 87, in ?     c.execute()   File "/opt/couchbase/lib/python/clitool.py", line 43, in execute     f[0](mc, *args[2:], **opts.__dict__)   File "/opt/couchbase/lib/python/cbflushctl", line 42, in set_param     mc.set_flush_param(key, val)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 214, in set_flush_param     return self._doCmd(memcacheConstants.CMD_SET_FLUSH_PARAM, key, val)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 104, in _doCmd     return self._handleSingleResponse(opaque)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 97, in _handleSingleResponse     cmd, opaque, cas, keylen, extralen, data = self._handleKeyedResponse(myopaque)   File "/opt/couchbase/lib/python/mc_bin_client.py", line 93, in _handleKeyedResponse     raise MemcachedError(errcode, rv) mc_bin_client.MemcachedError: Memcached error #1: Unknown config param [ root@localhost ~]#

Junyi Xie added a comment - 23/May/12 4:50 PM Hi Dipiti, The fix has been merged to 1.8.1 as CBD-152. http://review.couchbase.org/#change,16283 Let me close this bug if it is ok with you. Thanks Junyi

Junyi Xie added a comment - 23/May/12 4:50 PM http://review.couchbase.org/#change,16283