Don't delete database files when node leaves cluster.

Thuan Nguyen added a comment - 20/Apr/12 5:47 PM Integrated in github-ns-server-2-0 #333 (See [ http://qa.hq.northscale.net/job/github-ns-server-2-0/333/ ])      MB-4564 Don't delete database files when node leaves cluster. (Revision ac961c9839396f64ef6c0ef56e5f298095a0da63)      Result = SUCCESS Aliaksey Kandratsenka : Files : * src/ns_memcached.erl * src/ns_cluster.erl * src/menelaus_web_buckets.erl * src/menelaus_web.erl * src/ns_storage_conf.erl * src/ns_rebalancer.erl

Aleksey Kondratenko added a comment - 09/Apr/12 9:12 PM http://review.couchbase.org/14628

Steve Yen added a comment - 09/Apr/12 5:53 PM alk predicts this evening ETA

Perry Krug added a comment - 09/Apr/12 1:56 PM I'd specifically like something that makes the user confirm that they understand that proceeding with whatever action will result in the deleting of files they may want to save. A log message after the fact doesn't give them the ability to recover that data.

Aleksey Kondratenko added a comment - 09/Apr/12 1:52 PM how you want user to be notifed? We can use user-visible log message or we can have alert-like thing.

Perry Krug added a comment - 09/Apr/12 9:46 AM Could we also add a task to notify the user when the files are about to be deleted (either in the wizard or when adding back / rebalancing)?

Aleksey Kondratenko added a comment - 07/Apr/12 6:15 PM Aliaksey took this. Decision was to don't touch files when node is ejected/failed over. But rid of them either in the middle of wizard or when rebalance back in starts.

Steve Yen added a comment - 03/Apr/12 4:45 PM Please document decision here.

Steve Yen added a comment - 30/Mar/12 3:47 PM Aliaksey still needs final requirements on how this needs to behave.

Perry Krug added a comment - 30/Jan/12 5:21 PM Oh, yes...then that's a good time as well too. My only concern would be that the current code path re-initializes the node when it gets failed over or removed so we'd have to change that behavior.

Aleksey Kondratenko added a comment - 30/Jan/12 4:57 PM that's when/if node is initialized via setup wizard as standalone cluster

Perry Krug added a comment - 30/Jan/12 4:52 PM I think the join cluster could be a fine situation to clean them up. What do you mean by re-initialized? This is really only needed as a fail-safe situation in case we need to recover the data from the node that was failed over or removed.

Aleksey Kondratenko added a comment - 30/Jan/12 4:34 PM Perry, you want files preserved for eternity or we can/should get rid of them when node is re-initialized or joins some cluster ?