Couchbase Java Client

Query.copy does not copy includeDocs property

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.1dp
  • Fix Version/s: None
  • Component/s: library
  • Security Level: Public
  • Labels:
    None
  • Environment:
    all java

Description

Query.java line 200 in function copy():
setIncludeDocs(willIncludeDocs());

Should be
query.setIncludeDocs(willIncludeDocs());

Paginated queries depend on copy() so paginatedQuery requiring the document fail with:
 java.lang.UnsupportedOperationException: This view result doesn't contain documents

Activity

Hide
Permalink
Steven Cooke added a comment -
Perhaps a better solution:

  /**
   * All values in args map must be immutable
   */
  private Query(Query src) {
    args = new HashMap<String, Object>(src.args);
    includedocs = src.willIncludeDocs();
  }

  public Query copy() {
    return new Query(this);
  }
Show
Steven Cooke added a comment - Perhaps a better solution:   /**    * All values in args map must be immutable    */   private Query(Query src) {     args = new HashMap<String, Object>(src.args);     includedocs = src.willIncludeDocs();   }   public Query copy() {     return new Query(this);   }

People

  • Assignee:
    Mike Wiederhold
    Reporter:
    Steven Cooke
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: