Couchbase Java Client

NPE encountered in the DefaultConnectionFactory as per CBSE-404

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1.4
  • Component/s: None
  • Security Level: Public
  • Labels:
    None

Description

NPE encountered in the DefaultConnectionFactory as per customer explanation in CBSE-404.
This JCBC targets to fix the code related to this problem.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Nitschinger added a comment -
Hi Deepti,

can you update me quickly what's going on there and what the proposed fix from your side is? Thanks.
Show
Michael Nitschinger added a comment - Hi Deepti, can you update me quickly what's going on there and what the proposed fix from your side is? Thanks.
Hide
Permalink
Deepti Dawar added a comment -
CouchbaseConnectionFactoryBuilder has a method buildCouchbaseConnection which when called before setting the values for DefaultHashAlgorithm and FailureMode, gives a null pointer in the toString method of DefaultConnectionFactory.

There are two ways of fixing this :

1) Null check is added in toString of DefaultConnectionFactory
2) Default values of DefaultHashAlgorithm and FailureMode are provided as constants in CouchbaseConnectionFactoryBuilder.

I am fixing it the first way.

You can have a look at :
http://review.couchbase.org/24968
Show
Deepti Dawar added a comment - CouchbaseConnectionFactoryBuilder has a method buildCouchbaseConnection which when called before setting the values for DefaultHashAlgorithm and FailureMode, gives a null pointer in the toString method of DefaultConnectionFactory. There are two ways of fixing this : 1) Null check is added in toString of DefaultConnectionFactory 2) Default values of DefaultHashAlgorithm and FailureMode are provided as constants in CouchbaseConnectionFactoryBuilder. I am fixing it the first way. You can have a look at : http://review.couchbase.org/24968
Hide
Permalink
Michael Nitschinger added a comment -
Has been merged into master.
Show
Michael Nitschinger added a comment - Has been merged into master.

People

  • Assignee:
    Deepti Dawar
    Reporter:
    Deepti Dawar
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: