Couchbase Java Client

Paginator object doesn't move onto next "page" correctly

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.1.2
  • Fix Version/s: 1.1.6
  • Component/s: library
  • Security Level: Public
  • Labels:
    None

Description

Customer found his own issue:
I had a look at the source code for the java driver and found the error there. It is in:

com.couchbase.client.protocol.views.Paginator.getNextPage()

Right after calculating the number of "remaining" keys, it sets the limit of the query to the remaining number of keys and re-runs the query. What is missing here is:

    q.setSkip(totalDocs);

To actually start from the entry after the last entry on the current page. I have tried this and it works. But there is more code in this method and it is not very easy to follow so important to make sure that this fits.


I am enclosing a diff.

Activity

Ascending order - Click to sort in descending order
Perry Krug made changes -
Field Original Value New Value
Description Customer found his own issue:
I had a look at the source code for the java driver and found the error there. It is in:

com.couchbase.client.protocol.views.Paginator.getNextPage()

Right after calculating the number of "remaining" keys, it sets the limit of the query to the remaining number of keys and re-runs the query. What is missing here is:

    q.setSkip(totalDocs);

To actually start from the entry after the last entry on the current page. I have tried this and it works. But there is more code in this method and it is not very easy to follow so important to make sure that this fits.

Got response containing: 50
Done iterating through page, #missing keys: 51
Got response containing: 50
Done iterating through page, #missing keys: 1
Got response containing: 1
Done iterating through page, #missing keys: 0

I am enclosing a diff. 		Customer found his own issue:
I had a look at the source code for the java driver and found the error there. It is in:

com.couchbase.client.protocol.views.Paginator.getNextPage()

Right after calculating the number of "remaining" keys, it sets the limit of the query to the remaining number of keys and re-runs the query. What is missing here is:

    q.setSkip(totalDocs);

To actually start from the entry after the last entry on the current page. I have tried this and it works. But there is more code in this method and it is not very easy to follow so important to make sure that this fits.


I am enclosing a diff.
Perry Krug made changes -
Link This issue depends on CBSE-394 [ CBSE-394 ]
Michael Nitschinger made changes -
Fix Version/s 1.1.3 [ 10496 ]
Priority Major [ 3 ] Blocker [ 1 ]
Michael Nitschinger made changes -
Planned Start (set to new fixed version's start date)
Planned End (set to new fixed version's start date)
Matt Ingenthron made changes -
Assignee Michael Nitschinger [ daschl ] Matt Ingenthron [ ingenthr ]
Matt Ingenthron made changes -
Planned End (re-schedule end date based on new assignee)
Matt Ingenthron made changes -
Assignee Matt Ingenthron [ ingenthr ] Michael Nitschinger [ daschl ]
Matt Ingenthron made changes -
Planned End (re-schedule end date based on new assignee)
Michael Nitschinger made changes -
Fix Version/s 1.1.4 [ 10514 ]
Fix Version/s 1.1.3 [ 10496 ]
Michael Nitschinger made changes -
Planned Start (set to new fixed version's start date)
Planned End (set to new fixed version's start date)
Michael Nitschinger made changes -
Fix Version/s 1.1.5 [ 10515 ]
Fix Version/s 1.1.4 [ 10514 ]
Michael Nitschinger made changes -
Planned Start (set to new fixed version's start date)
Planned End (set to new fixed version's start date)
Michael Nitschinger made changes -
Fix Version/s 1.1.6 [ 10531 ]
Fix Version/s 1.1.5 [ 10515 ]
Michael Nitschinger made changes -
Rank Ranked higher
Michael Nitschinger made changes -
Rank Ranked higher
Michael Nitschinger made changes -
Sprint Sprint 1 - CW 19 & 20 [ 13 ]
Michael Nitschinger made changes -
Status Open [ 1 ] In Progress [ 3 ]
Michael Nitschinger made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Michael Nitschinger
    Reporter:
    Perry Krug
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Agile