Couchbase Java Client

append/incr/decr/add/replace should not require CAS value to be passed

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 1.1.7
  • Component/s: docs, library
  • Security Level: Public
  • Labels:
    None

Description

In the current implementation, there is no method for a non-CAS version of the append/prepend/incr/decr/add/replace operations. As per the memcached protocol, these operations do not require (but may be used with) a CAS id and requiring one greatly reduces the performance available by requiring a gets prior to the operation.

Perry

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. JCBC-143 Prepend should not require CAS

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Raghavan Srinivas added a comment -
The incr, decr, add and replace do have calls that do not require CAS Id. For the append and prepend methods

you could do something like this

     c.prepend(0, "prepend-key", "value");

which would not require a CAS to be supplied/fetched. Will this suffice for now?

My suggestion would be to close this issue and open a separate issue for just append and prepend if it's still deemed a bug.

 
Show
Raghavan Srinivas added a comment - The incr, decr, add and replace do have calls that do not require CAS Id. For the append and prepend methods you could do something like this      c.prepend(0, "prepend-key", "value"); which would not require a CAS to be supplied/fetched. Will this suffice for now? My suggestion would be to close this issue and open a separate issue for just append and prepend if it's still deemed a bug.  
Hide
Permalink
Michael Nitschinger added a comment -
http://review.couchbase.org/#/c/23486/
Show
Michael Nitschinger added a comment - http://review.couchbase.org/#/c/23486/
Hide
Permalink
Perry Krug added a comment -
This will need a docs update as well...
Show
Perry Krug added a comment - This will need a docs update as well...
Hide
Permalink
Perry Krug added a comment -
Michael, just to add here, I think it would be sufficient to document this rather than changing the API itself. Documenting that you can (and should!) pass 0 for the CAS value when using these operations.
Show
Perry Krug added a comment - Michael, just to add here, I think it would be sufficient to document this rather than changing the API itself. Documenting that you can (and should!) pass 0 for the CAS value when using these operations.

People

  • Assignee:
    Michael Nitschinger
    Reporter:
    Perry Krug
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:

Agile